Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The feedback emojis modal takes 5+ seconds to load on some devices #2485

Open
SamMakesThings opened this issue Sep 25, 2024 · 2 comments
Open
Labels
bug Something isn't working

Comments

@SamMakesThings
Copy link

As the title says, the feedback emoji selection model can take over 5 seconds to load on some devices every time. This was reported on Mac OS Safari, but it seems to also occur on Chrome on that user's device. I wasn't able to replicate it on my own in Safari or Chrome.

Looking in Chrome DevTools, the problem seems to be that the system is re-fetching every emoji image every time the model is opened. We might consider caching those images for performance / efficiency purposes.

image

Again, I wasn't able to replicate, so take this with a grain of salt. Probably a low priority improvement.

Initially reported by Alex Reibman.

@SamMakesThings SamMakesThings added the bug Something isn't working label Sep 25, 2024
@andrewtruong
Copy link
Collaborator

Thanks, I think I've also seen this issue raised before -- cc: @jamie-rasmussen

@jamie-rasmussen
Copy link
Collaborator

The internal ticket is https://wandb.atlassian.net/browse/WB-21093 and a related ticket on the library we use is ealush/emoji-picker-react#404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants