Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCE] Improve structure in transducer related classes #436

Open
faridyagubbayli opened this issue Jul 9, 2024 · 0 comments
Open

[ENHANCE] Improve structure in transducer related classes #436

faridyagubbayli opened this issue Jul 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@faridyagubbayli
Copy link
Collaborator

Description of the Enhancement

Two classes for representing and working with transducer, kWaveTransducerSimple and NotATransducer, can be improved in terms of code structure and clarity.

Justification for the Enhancement

  1. Currently, the boundary between the transducer and it's usage is not clear.
  2. Naming of the classes are not the best. We chose these names back then for the sake of time efficieny but it is time to improve this.
  3. Clear separation will help with writing tests and overall code quality.

Impact of Changes

Better naming, clear ownership of the properties and separation between definition and usage of the transducer.

Screenshots/Examples

Additional Context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@faridyagubbayli