Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to favourite current Setup page #12

Open
Astisme opened this issue Feb 13, 2024 · 3 comments
Open

Add button to favourite current Setup page #12

Astisme opened this issue Feb 13, 2024 · 3 comments

Comments

@Astisme
Copy link

Astisme commented Feb 13, 2024

I think it would be great to add a button shortcut to favourite the page the user is on.
The button could be camouflaged as one of the normal ones like these ones
image
or even better it could show up at the page header after the other buttons (if any)
image
For solution n. 2, the CSS selector where to put the button is #setupComponent .overflow.uiBlock > div.bRight
and this would be the button
<button aria-live="off" type="button" class="slds-button slds-button--neutral uiButton" aria-label="" data-aura-rendered-by="3:829;a" data-aura-class="uiButton"><span dir="ltr" class=" label bBody" data-aura-rendered-by="6:829;a">Favourite this page</span></button>
image
Then all the why-salesforce magic can happen by getting the link from window.location.

Do you want me to take a look at this?

@kryvyifedir
Copy link

@Astisme wouldn't it make sense to make current "Add" button to pre-populate URL value using current URL when possible?
So the user flow would be something like:

  1. Navigate to page that needs to be added as a tab
  2. Click on Extension Icon
  3. Click "Add"
  4. Tab name is automatically saved from current setup page Title, and tab URL from current URL
  5. Click Save

FYI @walters954

@kryvyifedir
Copy link

Also, "Favorite this page" is a bit misleading. How about "Save as a Tab"?

@Astisme
Copy link
Author

Astisme commented Jul 4, 2024

On my current implementation, I've removed the Add and the Save buttons so this would not be used.
I agree to change the name of this new button to Save as Tab but it seems like Warren does not check GitHub and I do not want to chase him around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants