Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regarding improvements in Documentation and codebase. #58

Open
SethiShivam opened this issue Oct 17, 2022 · 0 comments
Open

Regarding improvements in Documentation and codebase. #58

SethiShivam opened this issue Oct 17, 2022 · 0 comments

Comments

@SethiShivam
Copy link

SethiShivam commented Oct 17, 2022

Hi @dombrn @philpotisk @waltkb ,

I think there are some very good capabilities available in walt id but information about that is missing in dev. guide ,

and there are really good things in code which can be made a bit easier for developers to implement that.

Creating Vc template for issuer
https://github.com/walt-id/waltid-ssikit-examples/blob/master/src/main/kotlin/id/walt/ssikitexamples/CustomCredential.kt

if you notice , you will find that this example is only available in kotlin codebase not in java codebase ,
and 2nd thing is , it will be really great and easy for people if we have a function available directly from the library ,
I am saying this because we are creating a custom class in test cases but is not available in any package.

and If you think that I am going wrong than please correct me

Best Regards
Sethi Shivam

Describe the solution you'd like

I guess there should be directly a method available which we can import in our class and pass the custom template as JSON string or key value pair (something similar).

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant