chore: unit test for duplicate message push #2852

darshankabariya · 2024-06-26T10:48:35Z

It's related to #2320

It's test duplicate message push from filter service node to filter client

github-actions · 2024-06-26T10:53:20Z

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2852

Built from 7749908

Ivansete-status

Thanks for this! I haven't checked in in deep detail but we need to have fast tests :)
Cheers

Ivansete-status · 2024-06-26T11:45:54Z

tests/wakunode_rest/test_rest_filter.nim

+      len(messages1.data) == 1
+
+    # Pause execution for 2 minutes to test TimeCache functionality of service node
+    sleep(120000)


Oh, unfortunately we can't wait for so long in a single test

agree, we should make it configurable and just configure a lower value for testing

@darshankabariya : I think you need to extend here the mountFilter with a defaulted TTL argument that can be passed to WakuFilter.new...

nwaku/waku/node/waku_node.nim

Line 439 in 18f7a0a

maxFilterCriteriaPerPeer: uint32 = filter_subscriptions.MaxFilterCriteriaPerPeer,

Than in the test code in the setup part, at testSetup.serviceNode.mountFilter add a test TTL delay as 1.seconds at max, but maybe 500.milliseconds also fine.

NagyZoltanPeter

Please adjust mountFilter with the dup check TTL config and than you are able to configure this test's timeout to be short.

NagyZoltanPeter · 2024-06-26T12:13:01Z

tests/wakunode_rest/test_rest_filter.nim

+      len(messages1.data) == 1
+
+    # Pause execution for 2 minutes to test TimeCache functionality of service node
+    sleep(120000)


@darshankabariya : I think you need to extend here the mountFilter with a defaulted TTL argument that can be passed to WakuFilter.new...

nwaku/waku/node/waku_node.nim

Line 439 in 18f7a0a

maxFilterCriteriaPerPeer: uint32 = filter_subscriptions.MaxFilterCriteriaPerPeer,

Than in the test code in the setup part, at testSetup.serviceNode.mountFilter add a test TTL delay as 1.seconds at max, but maybe 500.milliseconds also fine.

darshankabariya · 2024-06-27T21:30:20Z

Please adjust mountFilter with the dup check TTL config and than you are able to configure this test's timeout to be short.

I’ve been updating the tests based on your suggestions. However, I encountered an issue with await testSetup.serviceNode.mountFilter(cacheTTL = 1.seconds). I just need to override this individual parameter, but it's showing a type mismatch (one is TimeInterval and the other is Duration) i try many thing but issue is persistence. In my local setup, the tests are not running correctly, but I will still push the changes to the branch. Sometimes my local environment behaves differently from the remote setup. Let’s see what happens. If you find anything wrong, please let me know.

NagyZoltanPeter · 2024-06-27T23:57:38Z

Please adjust mountFilter with the dup check TTL config and than you are able to configure this test's timeout to be short.

I’ve been updating the tests based on your suggestions. However, I encountered an issue with await testSetup.serviceNode.mountFilter(cacheTTL = 1.seconds). I just need to override this individual parameter, but it's showing a type mismatch (one is TimeInterval and the other is Duration) i try many thing but issue is persistence. In my local setup, the tests are not running correctly, but I will still push the changes to the branch. Sometimes my local environment behaves differently from the remote setup. Let’s see what happens. If you find anything wrong, please let me know.

Yeah, saw and fixed that. It was a wrong import std/times instead of chronos/timer. Now it compiles I think.

NagyZoltanPeter

I think it will be ok now with 1 sec delay for test.

NagyZoltanPeter

Compile error is fixed but test fails unfortunately:

2024-06-28T00:09:14.7098245Z   /home/runner/work/nwaku/nwaku/build/all_tests_waku 'Waku v2 Rest API - Filter V2::duplicate message push to filter subscriber ( sleep in between )'
2024-06-28T00:09:14.7099205Z ----------------------------------------------------------------
2024-06-28T00:09:14.7099981Z     /home/runner/work/nwaku/nwaku/tests/wakunode_rest/test_rest_filter.nim(462, 26): Check failed: len(messages2.data) == 1
2024-06-28T00:09:14.7100699Z     len(messages2.data) was 0
2024-06-28T00:09:14.7100903Z 
2024-06-28T00:09:14.7101289Z   [FAILED ] (  0.02s) duplicate message push to filter subscriber ( sleep in between )�[0m
2024-06-28T00:09:14.7101714Z 
2024-06-28T00:09:14.7101870Z (0.09s)   Waku v2 Rest API - Filter V2```

NagyZoltanPeter

As soon as the tests pass it is very well done!!!

NagyZoltanPeter · 2024-06-28T08:20:07Z

tests/wakunode_rest/test_rest_filter.nim

+      len(messages1.data) == 1
+
+    # Pause execution for 2 minutes to test TimeCache functionality of service node
+    sleep(1000)


I see, it was the issue!
Maybe to change it for a more commonly used version:

Suggested change

sleep(1000)

await sleepAsync(1.seconds)

Just a side note: using async sleep will not stop the whole thread so async tests can run meanwhile.

await sleepAsync(1.seconds)

oh that's awesome !

NagyZoltanPeter · 2024-06-28T08:20:24Z

tests/wakunode_rest/test_rest_filter.nim

+      postMsgResponse1.data == "OK"
+      len(messages1.data) == 1
+
+    # Pause execution for 2 minutes to test TimeCache functionality of service node


Suggested change

# Pause execution for 2 minutes to test TimeCache functionality of service node

# Pause execution for 1 second to test TimeCache functionality of service node

Ivansete-status

LGTM! Thanks! Make sure Zoltán's comments are considered before merging :)

darshankabariya · 2024-06-28T10:36:10Z

LGTM! Thanks! Make sure Zoltán's comments are considered before merging :)

Sure !

github-actions bot assigned darshankabariya Jun 26, 2024

darshankabariya requested review from NagyZoltanPeter, Ivansete-status and gabrielmer June 26, 2024 10:52

Ivansete-status reviewed Jun 26, 2024

View reviewed changes

NagyZoltanPeter requested changes Jun 26, 2024

View reviewed changes

darshankabariya force-pushed the unit_test_rest_filter branch from 1dfd377 to 9cfaf90 Compare June 27, 2024 20:08

NagyZoltanPeter approved these changes Jun 27, 2024

View reviewed changes

NagyZoltanPeter requested changes Jun 28, 2024

View reviewed changes

darshankabariya and others added 5 commits June 28, 2024 11:17

chore: add unit test for duplicate message push

ff76bee

chore: speedup the unit test and create better variable

1ab08ed

chore: update cacheTTL to 1.seconds

dd3ea78

chore: better naming converntion

9dfa363

Fix test compilation bug due wrong import

8a68bd4

darshankabariya force-pushed the unit_test_rest_filter branch from 13f0baf to 8a68bd4 Compare June 28, 2024 05:48

darshankabariya added 3 commits June 28, 2024 11:40

chore: import chronos timer instead of os

5b067ab

chore: resolve identation issue

4fbf5a6

chore: resolve identation issue

aada94b

NagyZoltanPeter approved these changes Jun 28, 2024

View reviewed changes

darshankabariya requested a review from Ivansete-status June 28, 2024 09:50

Ivansete-status approved these changes Jun 28, 2024

View reviewed changes

chore: update to async sleep

9785d55

darshankabariya merged commit 31c632e into master Jun 28, 2024
8 of 10 checks passed

darshankabariya deleted the unit_test_rest_filter branch June 28, 2024 12:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: unit test for duplicate message push #2852

chore: unit test for duplicate message push #2852

darshankabariya commented Jun 26, 2024

github-actions bot commented Jun 26, 2024 •

edited

Loading

Ivansete-status left a comment

Ivansete-status Jun 26, 2024

gabrielmer Jun 26, 2024

NagyZoltanPeter Jun 26, 2024

NagyZoltanPeter left a comment

NagyZoltanPeter Jun 26, 2024

darshankabariya commented Jun 27, 2024 •

edited

Loading

NagyZoltanPeter commented Jun 27, 2024

NagyZoltanPeter left a comment

NagyZoltanPeter left a comment

NagyZoltanPeter left a comment

NagyZoltanPeter Jun 28, 2024

NagyZoltanPeter Jun 28, 2024

darshankabariya Jun 28, 2024

NagyZoltanPeter Jun 28, 2024

Ivansete-status left a comment

darshankabariya commented Jun 28, 2024

	# Pause execution for 2 minutes to test TimeCache functionality of service node
	# Pause execution for 1 second to test TimeCache functionality of service node

chore: unit test for duplicate message push #2852

chore: unit test for duplicate message push #2852

Conversation

darshankabariya commented Jun 26, 2024

github-actions bot commented Jun 26, 2024 • edited Loading

Ivansete-status left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NagyZoltanPeter left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

darshankabariya commented Jun 27, 2024 • edited Loading

NagyZoltanPeter commented Jun 27, 2024

NagyZoltanPeter left a comment

Choose a reason for hiding this comment

NagyZoltanPeter left a comment

Choose a reason for hiding this comment

NagyZoltanPeter left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ivansete-status left a comment

Choose a reason for hiding this comment

darshankabariya commented Jun 28, 2024

github-actions bot commented Jun 26, 2024 •

edited

Loading

darshankabariya commented Jun 27, 2024 •

edited

Loading