fix(rln-relay): clear nullifier log only if length is over max epoch gap #2836
Conversation
|
You can find the image built from this PR at Built from 6cc5fce |
rymnc
force-pushed
the
fix-epoch-log-clearing
branch
from
6442063 to
32b3f6f
Compare
|
Thanks for this. Would it be possible to add a unit test to catch this edge case? |
rymnc
force-pushed
the
fix-epoch-log-clearing
branch
from
6463775 to
6363e7a
Compare
rymnc
force-pushed
the
fix-epoch-log-clearing
branch
from
6363e7a to
ef242e7
Compare
added in ef242e7, previously we did not test for multiple epoch sizes, this test ensures it for 1,5,10,30, and 60. |
|
|
||
| check: wakuRlnRelay.nullifierLog.len().uint == rlnMaxEpochGap | ||
|
|
||
| # append one more now |
There was a problem hiding this comment.
two things:
wondering if all this repeated code can be avoided by reusing the for i in 0..<rlnMaxEpochGap:. unsure if removing the < may help? afaik the intention here is to add rlnMaxEpochGap + 1 nullifier and see that clearNullifierLog doesn't clean them.
and for completeness, perhaps we should check that clearNullifierLog does clean the log when expected? meaning i keep adding and len()keeps beingrlnMaxEpochGap`?
* CHANGELOG.md add info for v0.30.0 * fix(rln-relay): clear nullifier log only if length is over max epoch gap (#2836) * chore: add TWN parameters for RLNv2 (#2843) * fix(rln): nullifierlog vulnerability (#2855) * chore(rln-relay): add chain-id flag to wakunode and restrict usage if mismatches rpc provider (#2858) --------- Co-authored-by: Aaryamann Challani <[email protected]> Co-authored-by: Alvaro Revuelta <[email protected]>
chore: Update master from release v0.30 (#2866) * CHANGELOG.md add info for v0.30.0 * fix(rln-relay): clear nullifier log only if length is over max epoch gap (#2836) * chore: add TWN parameters for RLNv2 (#2843) * fix(rln): nullifierlog vulnerability (#2855) * chore(rln-relay): add chain-id flag to wakunode and restrict usage if mismatches rpc provider (#2858) --------- Co-authored-by: Aaryamann Challani <[email protected]> Co-authored-by: Alvaro Revuelta <[email protected]>
Description
Fixes an edge case where the nullifier log was cleared when maxEpochGap == nullifierLog.len
Changes