Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): use --tags to match non-annotated tags #2814

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

jakubgs
Copy link
Contributor

@jakubgs jakubgs commented Jun 14, 2024

Currently tags used in the project are a mix of annotated and non-annotated/lightweight tags. Without --tags flag git describe will not take into account annotated tags.

Depends on:

Currently tags used in the project are a mix of annotated and
non-annotated/lightweight tags. Without `--tags` flag `git describe`
will not take into account annotated tags.

Signed-off-by: Jakub Sokołowski <[email protected]>
@jakubgs jakubgs requested a review from Ivansete-status June 14, 2024 19:46
@jakubgs jakubgs self-assigned this Jun 14, 2024
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! 💯

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@darshankabariya darshankabariya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks

@Ivansete-status Ivansete-status merged commit 317c83d into master Jun 19, 2024
11 checks passed
@Ivansete-status Ivansete-status deleted the ci/fix-git-describe branch June 19, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants