Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rlnv2): rlnv2 fork feature branch [dont merge] #2759

Closed
wants to merge 8 commits into from
Closed

feat(rlnv2): rlnv2 fork feature branch [dont merge] #2759

wants to merge 8 commits into from

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Jun 3, 2024 •
edited
Loading

Description

This PR will be used as a feature branch for the upcoming rln-v2 fork.

Pending PRs to be merged into it -

Changes

  • only use rln-v2, remove references of rln-v1
  • updated contract interface

Issue

Addresses #2758

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2759-rln-v1

Built from f45fb39

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2759-rln-v2

Built from f45fb39

@rymnc rymnc marked this pull request as ready for review June 3, 2024 09:39
@rymnc rymnc changed the title feat(rlnv2): rlnv2 fork feature branch feat(rlnv2): rlnv2 fork feature branch [dont merge] Jun 3, 2024
@alrevuelta
Copy link
Contributor

Thanks, looks good.

@alrevuelta alrevuelta mentioned this pull request Jun 4, 2024
Closed
25 tasks
@rymnc rymnc mentioned this pull request Jun 4, 2024
Merged
3 tasks
Ivansete-status
Ivansete-status reviewed Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! 💯
I'm not approving it because we won't merge it yet :)

@rymnc rymnc added this to the v0.30.0 milestone Jun 12, 2024
@rymnc rymnc linked an issue Jun 12, 2024 that may be closed by this pull request
chore(rlnv2): tracking issue for changes required for rlnv2 fork #2758
Closed
3 tasks
@rymnc rymnc requested a review from Ivansete-status June 12, 2024 09:12
alrevuelta
alrevuelta approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. great work on this thanks.

@Ivansete-status
Copy link
Collaborator

@rymnc - We need to block this PR until we overcome #2783
Once we merge this PR, we will create the release/v0.30 from there
( cc @alrevuelta )

@rymnc rymnc changed the title feat(rlnv2): rlnv2 fork feature branch [dont merge] feat(rlnv2): rlnv2 fork feature branch Jun 17, 2024
@rymnc
Copy link
Contributor Author

rymnc commented Jun 17, 2024

@Ivansete-status can we merge now?

@vpavlin vpavlin mentioned this pull request Jun 18, 2024
Draft
3 tasks
Ivansete-status
Ivansete-status approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks so much!
@rymnc - Sorry for the delay responding. The release v0.29.0 has been released yesterday (19 Jun 2024.)

@github-actions GitHub Actions
Copy link

This PR may contain changes to configuration options of one of the apps.

If you are introducing a breaking change (i.e. the set of options in latest release would no longer be applicable) make sure the original option is preserved with a deprecation note for 2 following releases before it is actually removed.

Please also make sure the label release-notes is added to make sure any changes to the user interface are properly announced in changelog and release notes.

@github-actions GitHub Actions
Copy link

This PR may contain changes to database schema of one of the drivers.

If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues.

Please make sure the label release-notes is added to make sure upgrade instructions properly highlight this change.

@rymnc rymnc changed the title feat(rlnv2): rlnv2 fork feature branch feat(rlnv2): rlnv2 fork feature branch [dont merge] Jun 20, 2024
@rymnc rymnc mentioned this pull request Jun 20, 2024
Merged
4 tasks
@rymnc
Copy link
Contributor Author

rymnc commented Jun 20, 2024

closing in favor of #2828

@rymnc rymnc closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@alrevuelta alrevuelta alrevuelta approved these changes

@gabrielmer gabrielmer Awaiting requested review from gabrielmer

Assignees

@rymnc rymnc

Labels
None yet
Projects
None yet
Milestone
v0.30.0
Development

Successfully merging this pull request may close these issues.

chore(rlnv2): tracking issue for changes required for rlnv2 fork
3 participants
@rymnc @alrevuelta @Ivansete-status