refactor: draft state machine #2656
Conversation
|
You can find the image built from this PR at Built from f569321 |
|
You can find the image built from this PR at Built from f569321 |
|
We still have to wrap the protocol then send a "end" payload from the client to have a clean stop on both side. |
|
The clean stop does not happen when running tests because the test end abruptly. |
|
About the closing of the connection, it seams like no other protocol do so, so I removed it. |
That is interesting, doesn't it cause the stream to stay open? Or when the object is GC'd the stream gets closed. Maybe worth investigating to confirm streams are not left dangling. |
SionoiS
force-pushed
the
type-state-machine
branch
4 times, most recently
from
147f6e3 to
d41f23b
Compare
Co-authored-by: Ivan FB <[email protected]> Co-authored-by: Prem Chaitanya Prathi <[email protected]>
SionoiS
force-pushed
the
type-state-machine
branch
from
d41f23b to
01c2f10
Compare
| periodicSyncFut: Future[void] | ||
| type WakuSync* = ref object of LPProtocol | ||
| storage: Storage | ||
| peerManager: PeerManager |
There was a problem hiding this comment.
Should we only keep a list of Store peers?
There was a problem hiding this comment.
That would be the responsibility of PeerManager no? Or do you meant instead of PeerManager?
* feat: Waku Sync Protocol * feat: state machine (#2656) * feat: pruning storage mehcanism (#2673) * feat: message transfer mechanism & tests (#2688) * update docker files * added ENR filed for sync & misc. fixes * adding new sync range param & fixes --------- Co-authored-by: Ivan FB <[email protected]> Co-authored-by: Prem Chaitanya Prathi <[email protected]>
First draft of the Waku sync type state machine. Much more difficult to do in Nim than Rust but it works.
@chaitanyaprem WDYT?