Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Copy back from nwaku-compose - an enhanced version of convenient node health check script #2624

Merged
merged 1 commit into from
Apr 25, 2024
Merged

chore: Copy back from nwaku-compose - an enhanced version of convenient node health check script #2624

merged 1 commit into from
Apr 25, 2024

Conversation

NagyZoltanPeter
Copy link
Contributor

Follow up PR on nwaku-compose waku-org/nwaku-compose#86

This enhancement to the script handles more edge cases and prints accordingly.

@NagyZoltanPeter NagyZoltanPeter self-assigned this Apr 24, 2024
SionoiS
SionoiS approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@SionoiS SionoiS left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but do we really need a health script?

The rest /health endpoint should be easy enough to use in nwaku no?

@NagyZoltanPeter
Copy link
Contributor Author

LGTM but do we really need a health script?

The rest /health endpoint should be easy enough to use in nwaku no?

Haha, check out node-help channel sometimes...
It's easier to tell anyone to run that script.

@SionoiS
Copy link
Contributor

SionoiS commented Apr 24, 2024

LGTM but do we really need a health script?
The rest /health endpoint should be easy enough to use in nwaku no?

Haha, check out node-help channel sometimes... It's easier to tell anyone to run that script.

Yeah that's fair. 🤣

gabrielmer
gabrielmer approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much!

@NagyZoltanPeter NagyZoltanPeter force-pushed the chore-enhance-chkhealth-script branch from 211e653 to eacea2d Compare April 25, 2024 08:30
@NagyZoltanPeter NagyZoltanPeter marked this pull request as ready for review April 25, 2024 08:30
@NagyZoltanPeter NagyZoltanPeter force-pushed the chore-enhance-chkhealth-script branch from eacea2d to c6fa0f7 Compare April 25, 2024 08:34
@NagyZoltanPeter NagyZoltanPeter merged commit 7f8d8e8 into master Apr 25, 2024
8 checks passed
@NagyZoltanPeter NagyZoltanPeter deleted the chore-enhance-chkhealth-script branch April 25, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielmer gabrielmer gabrielmer approved these changes

@SionoiS SionoiS SionoiS approved these changes

@Ivansete-status Ivansete-status Awaiting requested review from Ivansete-status

Assignees

@NagyZoltanPeter NagyZoltanPeter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NagyZoltanPeter @SionoiS @gabrielmer