Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enabling rest api by default #2600

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Conversation

gabrielmer
Copy link
Contributor

@gabrielmer gabrielmer commented Apr 18, 2024

Description

Enabling node's REST server by default

Changes

  • changing --rest CLI param's default value from false to true

Issue

closes #2137

@gabrielmer gabrielmer self-assigned this Apr 18, 2024
@gabrielmer gabrielmer changed the title chore: enabling rest api as default chore: enabling rest api by default Apr 18, 2024
Copy link

github-actions bot commented Apr 18, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2600-rln-v2-false

Built from 46d3fce

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank U for taking care of it!

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is reasonable :)

Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2600-rln-v2

Built from f8dfdb5

Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2600-rln-v1

Built from f8dfdb5

@gabrielmer gabrielmer merged commit 6bc79bc into master Apr 23, 2024
13 of 15 checks passed
@gabrielmer gabrielmer deleted the enabling-rest-api-by-default branch April 23, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: enable rest api interface by default on wakunode
3 participants