Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add log and archive message ingress for sync #3133

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

SionoiS
Copy link
Contributor

@SionoiS SionoiS commented Oct 21, 2024

Closes #3131 & #3132

@SionoiS SionoiS requested review from stubbsta and a team October 21, 2024 20:06
@SionoiS SionoiS self-assigned this Oct 21, 2024
Copy link

github-actions bot commented Oct 21, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3133

Built from 1a09dcc

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much!

waku/waku_archive/archive.nim Outdated Show resolved Hide resolved

(await self.driver.put(msgHash, pubsubTopic, msg)).isOkOr:
waku_archive_errors.inc(labelValues = [insertFailure])
trace "failed to insert message",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we log the failures at debug or error level? or it's something that happens a lot?

Copy link
Contributor Author

@SionoiS SionoiS Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 it should not fail often but if it does then many 100s of this error would be logged.

@SionoiS SionoiS requested a review from a team October 22, 2024 11:45
@SionoiS SionoiS requested review from darshankabariya, NagyZoltanPeter and Ivansete-status and removed request for a team and stubbsta October 22, 2024 15:16
Copy link
Contributor

@darshankabariya darshankabariya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@SionoiS SionoiS merged commit 80c7581 into master Oct 23, 2024
10 of 11 checks passed
@SionoiS SionoiS deleted the fix--archive-ignoring-sync-messages branch October 23, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: add a path for waku sync to bypass the timestamp check of 'validate'
3 participants