chore: waku_keystore: give some more context in case of error #3064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 2583976 |
Ivansete-status
requested review from
richard-ramos,
gabrielmer,
NagyZoltanPeter and
darshankabariya
richard-ramos
approved these changes
Oct 2, 2024
NagyZoltanPeter
approved these changes
Oct 2, 2024
| return err( | ||
| AppKeystoreError( | ||
| kind: KeystoreJsonError, | ||
| msg: "error in conversion_utils decode: " & getCurrentExceptionMsg(), |
There was a problem hiding this comment.
If it will be for the public ... like logs for our node-runners I would rather formalize like:
error during decoding credentials:
waku/waku_keystore/keystore.nim
Outdated
| err( | ||
| AppKeystoreError( | ||
| kind: KeystoreOsError, | ||
| msg: "error in createAppKeystore: " & getCurrentExceptionMsg(), |
There was a problem hiding this comment.
If it will be for the public ... like logs for our node-runners I would rather formalize like:
error while writing keystore:
waku/waku_keystore/keystore.nim
Outdated
| return err( | ||
| AppKeystoreError( | ||
| kind: KeystoreJsonError, | ||
| msg: "error in loadAppKeystore: " & getCurrentExceptionMsg(), |
There was a problem hiding this comment.
Similarly:
error during loading keystore:
darshankabariya
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.