Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not mount lightpush without relay #2808

Open
2 tasks
shash256 opened this issue Jun 13, 2024 · 2 comments
Open
2 tasks

chore: do not mount lightpush without relay #2808

shash256 opened this issue Jun 13, 2024 · 2 comments
Labels
effort/days Estimated to be completed in a few days, less than a week

Comments

@shash256
Copy link
Contributor

shash256 commented Jun 13, 2024

Background

This is a follow-on for a point raised by @NagyZoltanPeter at regarding mounting lightpush without relay.

Details

It was like this before in waku_node.nim and now in waku_lightpush/callbacks.nim . But given a mounted relay is needed for a lightpush service node, it is a question of why we would want to still mount it and not fail early.

Acceptance criteria

  • Gather consensus on whether we would want to fail early and not start a missconfigured node with lightpush and without relay (@jm-clius @SionoiS @gabrielmer )
  • If we agree on doing it, then go ahead with implementation
@jm-clius
Copy link
Contributor

No strong opinions here, but conceptually we've decoupled lightpush from having any other protocol dependencies - in other words, lightpush is now simply the protocol for directly pushing a message to a service node. The services provided by this service node is currently limited to Relay, but it could in future be any other service (such as Store, etc.). Lightpush should then be mounted without reference to other protocols and only individual lightpush requests should succeed or fail based on the secondary protocols and services requested by the client.

@NagyZoltanPeter
Copy link
Contributor

It is right, but see the case if there is a running service node in the network having just able to reply error.
It will be the same for such case if dependent services are not present.
My intention was with the comment made on Akhil's changes that if I configure a node to have lightpush might want to notice early that I miss-configured my node. In this sense I mean to fail rather early than having bulk error messages for possible clients.

@Ivansete-status Ivansete-status added the effort/days Estimated to be completed in a few days, less than a week label Jun 25, 2024
@Ivansete-status Ivansete-status moved this to To Do in Waku Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/days Estimated to be completed in a few days, less than a week
Projects
Status: To Do
Development

No branches or pull requests

4 participants