Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extract common prefixes into a constant for multiple query #2747

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

darshankabariya
Copy link
Contributor

Solution of #2744 "chore: extract select to a const"

Refactored similar query select parts into a constant for clarity.

Copy link

This PR may contain changes to database schema of one of the drivers.

If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues.

Please make sure the label release-notes is added to make sure upgrade instructions properly highlight this change.

Copy link

github-actions bot commented May 30, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2747-rln-v1

Built from f53c50e

Copy link

github-actions bot commented May 30, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2747-rln-v2

Built from f53c50e

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiiiice! Looks great :))

Thanks so much!

Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer thanks!

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks !
I'm adding just a tiny suggestion to make sure there is always a space added at the end

@darshankabariya darshankabariya merged commit dfc979a into master Jun 3, 2024
13 of 15 checks passed
@darshankabariya darshankabariya deleted the chore_2744 branch June 3, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants