-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: extract common prefixes into a constant for multiple query #2747
Conversation
This PR may contain changes to database schema of one of the drivers. If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues. Please make sure the label |
You can find the image built from this PR at
Built from f53c50e |
You can find the image built from this PR at
Built from f53c50e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niiiiiice! Looks great :))
Thanks so much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much nicer thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks !
I'm adding just a tiny suggestion to make sure there is always a space added at the end
71ddd35
to
53cb7b4
Compare
…ring merging. Signed-off-by: DarshanBPatel <[email protected]>
53cb7b4
to
3f863e7
Compare
Solution of #2744 "chore: extract select to a const"
Refactored similar query select parts into a constant for clarity.