Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rate limit phase#3 - peer request rate registration and prioritization #2683

Closed
Tracked by #2032
NagyZoltanPeter opened this issue May 8, 2024 · 0 comments
Closed
Tracked by #2032
Assignees
Labels
E:nwaku Node Bandwidth Management Features effort/days Estimated to be completed in a few days, less than a week

Comments

@NagyZoltanPeter
Copy link
Contributor

NagyZoltanPeter commented May 8, 2024

Problem

Phase1 and 2 of rate limiting non relay protocols added a yet simple approach of deny request that are over some predefined limits. This still leaves open attack vector for malicious peers to DOS service nodes and can prevent other service client peers to use the facility properly.

Suggested solution

To overcome this situation rate limit management will be extended with a per peer usage rank to filter out or de-prioritize such peers that gives the most of the requests. This is needed for all the protocols but for filter service definitely as of its nature of subscribe and ping method of managing subscriptions by peers.

Parent issue

#2032

@NagyZoltanPeter NagyZoltanPeter self-assigned this May 8, 2024
@NagyZoltanPeter NagyZoltanPeter moved this to In Progress in Waku May 8, 2024
@gabrielmer gabrielmer added the effort/days Estimated to be completed in a few days, less than a week label Jun 4, 2024
@NagyZoltanPeter NagyZoltanPeter moved this from In Progress to Code Review / QA in Waku Jul 15, 2024
@NagyZoltanPeter NagyZoltanPeter moved this from Code Review / QA to Done in Waku Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:nwaku Node Bandwidth Management Features effort/days Estimated to be completed in a few days, less than a week
Projects
Archived in project
Development

No branches or pull requests

3 participants