Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rln-relay): enforce error callback to remove exception raised from retryWrapper #2622

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Apr 23, 2024

Description

To address something that is blocking #2607, this is necessary to remove possibilities of exceptions being raised in the retryWrapper template.

Changes

  • remove default value for errCallback

Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2622-rln-v2

Built from 625c205

Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2622-rln-v1

Built from 625c205

@rymnc rymnc marked this pull request as ready for review April 23, 2024 15:38
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! ❤️

@rymnc rymnc merged commit 9c9883a into master Apr 24, 2024
14 of 16 checks passed
@rymnc rymnc deleted the resultify-retry-wrapper branch April 24, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants