Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rln): set a minimum epoch gap #2555

Merged
merged 2 commits into from
Mar 27, 2024
Merged

fix(rln): set a minimum epoch gap #2555

merged 2 commits into from
Mar 27, 2024

Conversation

alrevuelta
Copy link
Contributor

Description

  • Fixes rlnMaxEpochGap, so that a minimum of 1 is set.
  • This produced a bug noticed in RLN v2 where setting a high rlnEpochSizeSec caused rlnMaxEpochGap=0 which caused problems in clearNullifierLog.

@alrevuelta alrevuelta requested a review from rymnc March 26, 2024 10:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2555-rln-v2-false

Built from c9274e2

@alrevuelta alrevuelta requested a review from jm-clius March 26, 2024 12:50
@alrevuelta alrevuelta merged commit b5e4795 into master Mar 27, 2024
13 of 15 checks passed
@alrevuelta alrevuelta deleted the fix-min-gap branch March 27, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@jm-clius jm-clius jm-clius approved these changes

@rymnc rymnc Awaiting requested review from rymnc

Assignees

@alrevuelta alrevuelta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alrevuelta @jm-clius @Ivansete-status