chore: factory cleanup #2523
Merged
chore: factory cleanup #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmer
requested review from
Ivansete-status,
SionoiS and
NagyZoltanPeter
and removed request for
SionoiS
|
You can find the image built from this PR at Built from 390cd05 |
SionoiS
approved these changes
Mar 11, 2024
| @@ -85,6 +85,38 @@ func node*(app: App): WakuNode = | |||
| func version*(app: App): string = | |||
| app.version | |||
|
|
|||
| ## Retrieve dynamic bootstrap nodes (DNS discovery) | |||
|
|
|||
| proc retrieveDynamicBootstrapNodes*(dnsDiscovery: bool, | |||
There was a problem hiding this comment.
I feel like this would be useful to many kind of apps but then without a plugin system of some sort... 🤷 maybe one day!
Ivansete-status
approved these changes
Mar 11, 2024
| @@ -85,6 +85,38 @@ func node*(app: App): WakuNode = | |||
| func version*(app: App): string = | |||
| app.version | |||
|
|
|||
| ## Retrieve dynamic bootstrap nodes (DNS discovery) | |||
|
|
|||
| proc retrieveDynamicBootstrapNodes*(dnsDiscovery: bool, | |||
There was a problem hiding this comment.
I think is better to keep this in the node_factory.nim so that the libwaku could potentially benefit from it when we add this feature. wdyt @jm-clius ?
There was a problem hiding this comment.
Sounds good to me :) Will wait a bit before merging so we confirm it and if so I'll update the PR 🤩
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleaning
node_factory.nim. Only exportingsetupNode()andstartNode().Changes
retrieveDynamicBootstrapNodes()toapp.nimnode_factory.nimIssue
extends #2441