Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wakucanary): add latency measurement using ping protocol #2074

Merged
merged 1 commit into from
Sep 26, 2023
Merged

feat(wakucanary): add latency measurement using ping protocol #2074

merged 1 commit into from
Sep 26, 2023

Conversation

vpavlin
Copy link
Member

@vpavlin vpavlin commented Sep 25, 2023

Description

Since this is very similar to #2068, I thought it might be interesting and useful to have the latency measured by wakucanary.

Set it on by default with a switch --ping=false to disable it

INF 2023-09-25 12:53:31.315+02:00 Peer response time (ms)                    tid=2064003 file=wakucanary.nim:110 peerId=16U*ZsXy69 ping=59

Changes

  • add --ping option
  • mount ping protocol
  • measure latency is --ping=true

@github-actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2074

Built from e065253

alrevuelta
alrevuelta approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@alrevuelta alrevuelta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! nice idea.

jakubgs
jakubgs approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

@vpavlin
Copy link
Member Author

vpavlin commented Sep 26, 2023

Merging even though js-waku test not passing, but that is for sure unrelated

@vpavlin vpavlin merged commit 6cb9a8d into master Sep 26, 2023
@vpavlin vpavlin deleted the feat/wakucanary-ping branch September 26, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubgs jakubgs jakubgs approved these changes

@alrevuelta alrevuelta alrevuelta approved these changes

@Ivansete-status Ivansete-status Awaiting requested review from Ivansete-status

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vpavlin @jakubgs @alrevuelta