Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HTTP REST API: Filter support v2 #1872

Closed
3 tasks done
Tracked by #1076
NagyZoltanPeter opened this issue Aug 2, 2023 · 2 comments · Fixed by #1890
Closed
3 tasks done
Tracked by #1076

feat: HTTP REST API: Filter support v2 #1872

NagyZoltanPeter opened this issue Aug 2, 2023 · 2 comments · Fixed by #1890
Assignees
Labels
E:REST API service node See https://github.com/waku-org/pm/issues/82 for details

Comments

@NagyZoltanPeter
Copy link
Contributor

NagyZoltanPeter commented Aug 2, 2023

Background

This forms a subtask of #1076 and follow up for #1851
Nwaku nodes operating as 12/WAKU2-FILTER clients can use the filter protocol to subscribe to service nodes to receive messages adhering to a set of subscription criteria.
While #1851 created Rest API interface for the Filter v1 - legacy implementation.
This one should implement new Filter subscription concept available through Rest interface.

Suggested solution

It should follow existing approach with taking care that separate v1 and v2 APIs. For a while they should live together.
Give a concise openapi descriptor.

Acceptance criteria

  • working HTTP Filter Client REST API to perform filter client operations on remote service nodes
  • sufficient unit tests for basic functionality
  • integration of Filter Client API into the wakunode2 app
@NagyZoltanPeter NagyZoltanPeter self-assigned this Aug 2, 2023
@NagyZoltanPeter NagyZoltanPeter moved this to In Progress in Waku Aug 4, 2023
@NagyZoltanPeter NagyZoltanPeter linked a pull request Aug 7, 2023 that will close this issue
8 tasks
@fryorcraken fryorcraken added the E:REST API service node See https://github.com/waku-org/pm/issues/82 for details label Sep 5, 2023
@NagyZoltanPeter
Copy link
Contributor Author

Weekly Update

@NagyZoltanPeter
Copy link
Contributor Author

NagyZoltanPeter commented Sep 18, 2023

Weekly Update

  • achieved: Filter v1 & v2 REST API endpoints merged to master
  • next: LightPush REST endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:REST API service node See https://github.com/waku-org/pm/issues/82 for details
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants