Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea(rln-relay): use rln-relay as a sub-protocol of waku-relay #1460

Closed
rymnc opened this issue Dec 13, 2022 · 3 comments
Closed

idea(rln-relay): use rln-relay as a sub-protocol of waku-relay #1460

rymnc opened this issue Dec 13, 2022 · 3 comments
Labels
E:RLN on mainnet see https://github.com/waku-org/pm/issues/98 for details effort/hours Estimated to be completed in a few hours track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications

Comments

@rymnc
Copy link
Contributor

rymnc commented Dec 13, 2022

Background

  1. Waku Relay
  2. Waku RLN Relay
  3. Pubsub topic message validation
  4. RLN Group Sync Layer

Details

In it's current state, waku rln relay is perceived as a protocol, whereas, it is a thin layer over waku-relay. It does not have a protocol id, as it uses waku-relay to send and receive messages. waku-relay provides message validation for a given pubsub topic, and we use the rln validation logic there. Therefore, all waku-rln-relay does, is message validation on a given pubsub topic.

There are misconfigurations possible with waku-rln-relay, when operators would like to run spam prevention, but do not realize they need to enable the waku-relay protocol for it to mount correctly.

This proposal aims to feature flag rln/rate-limiting within waku-relay, where it is mounted in tandem with waku-relay, and each form of message validation in rln (which is directly related to the group synchronization) is a different pubsub validator that is applied depending on the configuration passed to waku-relay.

Semantically, this aligns more with the rln/rlnp2p vision and also clears confusion re: the real function of waku-rln-relay.

Acceptance criteria

  • TBD: will be fleshed out if proposal passes
@rymnc rymnc added question track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications labels Dec 13, 2022
@rymnc rymnc moved this to New in Vac Research Jan 16, 2023
@rymnc rymnc moved this from New to Review/QA in Vac Research Jan 16, 2023
@rymnc rymnc added track:rlnp2p and removed track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications labels Jan 19, 2023
@vpavlin vpavlin added this to Waku Jul 15, 2023
@vpavlin vpavlin moved this to To Do in Waku Jul 15, 2023
@vpavlin vpavlin added track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications E:2023-rln labels Aug 8, 2023
@fryorcraken
Copy link
Collaborator

@alrevuelta @jm-clius should this be part of Epic 3.2? ?

@jm-clius
Copy link
Contributor

Not sure how relevant this still is (I think a lot of the work here has already been done @rymnc ?). Nevertheless, no Epic 3.2 is meant to track the critical MVP for RLN in production, where this is a general improvement not part of the Gen 0 milestone (i.e. we don't need this to be closed to launch).

@fryorcraken fryorcraken added the E:RLN on mainnet see https://github.com/waku-org/pm/issues/98 for details label Oct 26, 2023
@Ivansete-status Ivansete-status added the effort/hours Estimated to be completed in a few hours label May 8, 2024
@rymnc
Copy link
Contributor Author

rymnc commented May 8, 2024

not planned since this will be replaced with pluggable validators.

@rymnc rymnc closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2024
@github-project-automation github-project-automation bot moved this from To Do to Done in Waku May 8, 2024
@github-project-automation github-project-automation bot moved this from Review/QA to Done in Vac Research May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:RLN on mainnet see https://github.com/waku-org/pm/issues/98 for details effort/hours Estimated to be completed in a few hours track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications
Projects
Archived in project
Development

No branches or pull requests

5 participants