Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(chat2): enable metrics #1203

Closed
2 tasks done
rymnc opened this issue Sep 30, 2022 · 2 comments · Fixed by #1279
Closed
2 tasks done

chore(chat2): enable metrics #1203

rymnc opened this issue Sep 30, 2022 · 2 comments · Fixed by #1279
Assignees
@rymnc
Labels
track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications

Comments

@rymnc
Copy link
Contributor

rymnc commented Sep 30, 2022 •
edited
Loading

Background

The metricsServer and metricsLogging flags are available as configuration parameters but are not setup in the chat2 initialization procedure. Metrics would be useful for those running chat2.

Details

Enable metricsLogging, similar to -
https://github.com/status-im/nwaku/blob/master/waku/v2/node/wakunode2.nim#L1160-L1161

Acceptance criteria
@rymnc rymnc added track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications track:maintenance labels Sep 30, 2022
@rymnc rymnc mentioned this issue Sep 30, 2022
Closed
10 tasks
@rymnc rymnc moved this to New in Vac Research Sep 30, 2022
@jm-clius jm-clius removed this from Waku Oct 5, 2022
@rymnc rymnc mentioned this issue Oct 13, 2022
Merged
@rymnc rymnc self-assigned this Oct 13, 2022
@staheri14
Copy link
Contributor

staheri14 commented Oct 14, 2022 •
edited
Loading

Is this issue in progress? if yes, then please move it to the in progress column.

@staheri14 staheri14 moved this from New to Now/In Progress in Vac Research Oct 14, 2022
@rymnc
Copy link
Contributor Author

rymnc commented Oct 18, 2022

Yes, this issue is in progress. The second step is a little more involved, and should be resolved soon

This was referenced Oct 18, 2022
Closed
Merged
@rymnc rymnc moved this from Now/In Progress to Done in Vac Research Oct 20, 2022
@rymnc rymnc moved this from Done to Review/QA in Vac Research Oct 20, 2022
Repository owner moved this from Review/QA to Done in Vac Research Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rymnc rymnc

Labels
track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(chat2): metrics server + metrics logging waku-org/nwaku
3 participants
@staheri14 @rymnc @jm-clius