Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rln-relay): handle Exceptions and CatchableErrors #1189

Closed
1 task done
rymnc opened this issue Sep 27, 2022 · 0 comments · Fixed by #1321
Closed
1 task done

chore(rln-relay): handle Exceptions and CatchableErrors #1189

rymnc opened this issue Sep 27, 2022 · 0 comments · Fixed by #1321
Assignees
@rymnc
Labels
track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications

Comments

@rymnc
Copy link
Contributor

rymnc commented Sep 27, 2022 •
edited
Loading

Background

context: #1185 (comment)

Details

Refactor functions into using the Result type, and raise the error as is

Acceptance criteria

  • Convert all functions that may raise an error into a result type
@rymnc rymnc added track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications track:maintenance labels Sep 27, 2022
@rymnc rymnc self-assigned this Sep 27, 2022
@rymnc rymnc mentioned this issue Sep 27, 2022
Merged
@rymnc rymnc moved this to Todo in Waku Sep 29, 2022
@rymnc rymnc moved this to Next/Backlog in Vac Research Sep 30, 2022
@jm-clius jm-clius removed this from Waku Oct 5, 2022
@staheri14 staheri14 mentioned this issue Oct 14, 2022
Closed
29 tasks
@rymnc rymnc mentioned this issue Nov 1, 2022
Merged
Repository owner moved this from Next/Backlog to Done in Vac Research Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rymnc rymnc

Labels
track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(rln-relay): remove all raises and replace with Result types waku-org/nwaku
1 participant
@rymnc