Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure playwright to test other examples based on env var #1597

Open
4 tasks
weboko opened this issue Sep 21, 2023 · 0 comments
Open
4 tasks

feat: configure playwright to test other examples based on env var #1597

weboko opened this issue Sep 21, 2023 · 0 comments
Labels
E:Comprehensive dev testing See https://github.com/waku-org/pm/issues/90 for details

Comments

@weboko
Copy link
Collaborator

weboko commented Sep 21, 2023

This is a feature request

Problem

In #1418 Playwright was configured to extract and test only one example which is web-chat.
We have other examples that are worth shallow testing in the browser - a reason for that is to check the compatibility of js-waku with different Fron-End frameworks.

Proposed Solutions

By passing env variables we can re-configure Pralywright CI to test other examples as well.
A new set of tests can be written for other examples and should be run dependently on an example under testing.

Subtasks

  • Configure Playwright CI to be an action for re-usability reasons;
  • Make bootstrap scripts example agnostic;
  • Write new set of test for other examples if needed;
  • Add CI stages to test different examples;

Notes

Refs: waku-org/pm#90

@fryorcraken fryorcraken added this to Waku Sep 21, 2023
@fryorcraken fryorcraken added the E:Comprehensive dev testing See https://github.com/waku-org/pm/issues/90 for details label Sep 22, 2023
@danisharora099 danisharora099 moved this to To Do in Waku Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:Comprehensive dev testing See https://github.com/waku-org/pm/issues/90 for details
Projects
Status: To Do
Development

No branches or pull requests

2 participants