Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate alternative to relay pings/why we need them #1349

Open
4 tasks
Tracked by #905 ...
danisharora099 opened this issue May 12, 2023 · 2 comments
Open
4 tasks
Tracked by #905 ...

investigate alternative to relay pings/why we need them #1349

danisharora099 opened this issue May 12, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@danisharora099
Copy link
Collaborator

Problem

#1189 (comment) made us aware that relay pings (sending messages over the relay protocol manually) are required to ensure connection stays alive.
This isn't ideal as we end up sending a lot of messages (maybe spam).

Proposed Solutions

This issue should track:

  • why we need relay pings
  • alternative to relay pings if possible
  • if we can reopen the connection after it closes (in 10 mins)
  • confirm if after 10 mins, does message sending and receiving both fail, or just receiving?

Notes

Refer to some investigation been done in #1189

@fryorcraken fryorcraken added this to Waku May 12, 2023
@fryorcraken
Copy link
Collaborator

The output of this issue should be:

  • relay ping are removed
  • Yet, a browser is able to use Relay for an extensive period of time (e.g. 1 hour)

@fryorcraken fryorcraken moved this to Triage in Waku May 15, 2023
@fryorcraken fryorcraken added the enhancement New feature or request label May 15, 2023
@fryorcraken
Copy link
Collaborator

At this point in time it does not really make sense to use Relay anyways because we can only connect to nodes via wss.
This issue can be addressed once Relay over WebRTC is done and we start to worry about connection management for it.

Let's keep the ping for now as some projects do use Relay. Do note that in terms of documentation, we will only push light client protocols.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To Do
Development

No branches or pull requests

2 participants