Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extensions list into settings field of import rules #78

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

wakamsha
Copy link
Owner

@wakamsha wakamsha commented Aug 22, 2024

Describe your changes

Fixed each extensions list in the settings field of the import rule. The main changes are as follows:

  • added a missing .
    - extensions: ['ts', 'mts'],
    + extensions: ['.ts', '.mts'],
  • added Typescript-related extensions.

These settings are not neccesary when using typescript-eslint in conjunction with essentials config, but they are required when using essentials alone, so I've fixed then.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.

@wakamsha wakamsha self-assigned this Aug 22, 2024
@wakamsha wakamsha changed the title fix: extensions list into settings field of import rules fix: extensions list into settings field of import rules Aug 22, 2024
@wakamsha wakamsha merged commit 65b4018 into main Aug 22, 2024
6 checks passed
@wakamsha wakamsha deleted the fix/extensions-list branch August 22, 2024 09:06
wakamsha pushed a commit that referenced this pull request Aug 22, 2024
## [3.0.1](v3.0.0...v3.0.1) (2024-08-22)

### Bug Fixes

* **deps:** update dependency eslint-plugin-jsdoc to v50 ([#76](#76)) ([72c0bfb](72c0bfb))
* **deps:** update dependency eslint-plugin-promise to v7 ([#72](#72)) ([3cb0ca3](3cb0ca3))
* extensions list into `settings` field of `import` rules ([#78](#78)) ([65b4018](65b4018))
@wakamsha
Copy link
Owner Author

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant