-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docs for NixOS css bug #3268
Conversation
Warning Rate Limit Exceeded@atterpac has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 38 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThis update brings a new Dockerfile that sets up an environment with necessary dependencies and installs Wails in a specific branch. Additionally, a guide addresses a font-size bug in NixOS/Wayland setups by adjusting Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
website/docs/guides/nixos-font.mdx
Outdated
@@ -0,0 +1,10 @@ | |||
# NixOS FontSize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title "NixOS FontSize" could be more descriptive to immediately inform the reader about the content's focus. Consider a title that reflects the workaround nature of the content, such as "Fixing Font Size Issue on NixOS/Wayland".
website/docs/guides/nixos-font.mdx
Outdated
@@ -0,0 +1,10 @@ | |||
# NixOS FontSize | |||
|
|||
NixOS/Wayland can cause a bug where the `font-size` css property does affect the rendered page. To fix this add the following to your devShell. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a minor typo in the description: "does affect" should be "does not affect". This correction is crucial for accurately conveying the problem being addressed.
- NixOS/Wayland can cause a bug where the `font-size` css property does affect the rendered page.
+ NixOS/Wayland can cause a bug where the `font-size` css property does not affect the rendered page.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
NixOS/Wayland can cause a bug where the `font-size` css property does affect the rendered page. To fix this add the following to your devShell. | |
NixOS/Wayland can cause a bug where the `font-size` css property does not affect the rendered page. To fix this add the following to your devShell. |
```shell | ||
shellHook = with pkgs; '' | ||
export XDG_DATA_DIRS=${gsettings-desktop-schemas}/share/gsettings-schemas/${gsettings-desktop-schemas.name}:${gtk3}/share/gsettings-schemas/${gtk3.name}:$XDG_DATA_DIRS; | ||
export GIO_MODULE_DIR="${pkgs.glib-networking}/lib/gio/modules/"; | ||
''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shell script provided is clear and seems appropriate for the described workaround. However, it would be beneficial to add a brief explanation of what each export
command does for readers who might not be familiar with these settings. This can enhance understanding and trust in the provided solution.
1a2c374
to
26d4063
Compare
add changelog Appeasing the rabbit remove v3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @atterpac 🙏
Adds docs to help resolve the issue of NixOS/Wayland not being able to change the font size
Fixes # (issue)
No issue, bug reported in discord help channel
Type of Change
Test Configuration
No functional changes made
Summary by CodeRabbit
font-size
rendering issues on NixOS/Wayland.