Link hover style #152
Merged
Link hover style #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All links in a documentation will be visited very soon. The value of coloring them different (especially the same as the hover style) is therefore questionable.
The theme is already using quite a few colors. In an attempt to consolidate all these colors and reduce the number of used colors, the teal on hover is now replaced with the underline/border color (green). On hover and active, line and text are now of the same color. This feels a bit cleaner to me.
The border was too far way and is influenced by the padding. This is not really what we wanted.
|
Looks good. Closing #143 in favour of this. |
Thanks for teeing this up 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a quick followup based on @PaarthAgarwal's work on #143.
This is addressing the focus style mentioned in the #143 review and reduces the number of colors used as was discussed in #78
Closes #143
Closes #148
Closes #78
Closes #22