Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appearance of links within code blocks #127

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Fix appearance of links within code blocks #127

merged 1 commit into from
Nov 29, 2021

Conversation

vsalvino
Copy link
Contributor

Links are still dark within code blocks, making them unreadable. This can happen from module reference generated from autodoc, e.g.

Before:

image

After:

image

@vsalvino vsalvino merged commit fbf0624 into wagtail:main Nov 29, 2021
@vsalvino vsalvino deleted the fix-viewcode-back branch November 29, 2021 22:27
@tbrlpld
Copy link
Collaborator

tbrlpld commented Nov 29, 2021

How can you have a working link the pre element? Shouldn't that render the markup? Weird

@tbrlpld
Copy link
Collaborator

tbrlpld commented Nov 29, 2021

If you have to display reserved characters such as <, >, &, " within the <pre> tag, the characters must be escaped using their respective HTML entity.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/pre

@vsalvino
Copy link
Contributor Author

I believe <pre> only preserves whitespace; it still allows other html tags within it, similar to a div.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants