-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase contrast of admonitions to WCAG AAA, inline code to AA #121
Conversation
Most of these changes look good to me, with one exception: I'm not sure if the contrast between the color of inline code and surrounding dark gray text is sufficient. I think the typical guidance for color change to indicate something like that (see also: link colors) is 3:1, but this new combo is only 2.29:1. I recognize that means we'll probably have to settle for not meeting the AAA standard for the inline code, but I think that's an acceptable tradeoff for more contrast with the surrounding text. How about |
Good point. I'm guess it might be somewhat impossible to meet both. AA contrast it is still considered "good", so that would probably be acceptable. In that case the original color for inline code is probably sufficient |
I think either way is fine, but I would think it's better to prioritize the contrast on white vs. the contrast with surrounding text, so for that reason (and the existence of #11 implying that others think it should have been darker anyway, even if it barely passed at 4.5:1), I'd go with the darker red I suggested in my comment. |
Ok, took your color and flipped blue and green values slightly (to skew it more bluish than greenish, to match the indigo vibe) to (updated screenshots in description) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #11 , also see discussion on #119
Color contrast of admonitions, version notices meets WCAG AAA standard. Inline code contrast has also been increased slightly to meet WCAG AA standard (is now 5.3:1), plus also meets 3:1 contrast ratio with surrounding text.
Overall the new colors are not as "shiny" but hopefully still match the look-and-feel. More shininess can be had if we are OK with lowering to WCAG AA standard.
Kept the colors mostly the same:
Admonitions:
Versions:
Inline code: