Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with stripe-php version 7 #16

Closed
acabrkic opened this issue Jul 20, 2020 · 5 comments
Closed

Compatibility with stripe-php version 7 #16

acabrkic opened this issue Jul 20, 2020 · 5 comments

Comments

@acabrkic
Copy link

Hello, we are using PHP 7.4 and when we install merx 1.4.0 rc-1 via composer, it says that it is compatible only with stripe-php packages 6.28^ and not compatible with php-stripe 7. This is not a big problem, but there is a line in ApiRequestor.php (line 402) that uses array_key_exists('request-id', $rheaders) and this does not work in php 7.4 as $rheaders is an object, so it is necessary to say (array)$rheaders . This is fixed in stripe-php 7.

Will merx be compatible with stripe-php ^7.0 soon?

@vitamin2ag
Copy link

looking also forward to this.

@tobiasfabian
Copy link
Member

Thanks for your feedback.

I’ll look into that this week.

@acabrkic
Copy link
Author

stripe/stripe-php#827 this is the link to the problem, sorry I forgot to mention it

@tobiasfabian
Copy link
Member

Hey @acabrkic and @vitamin2ag,

I’ve upgraded the stripe composer module to 7.22 and experienced no issues. There is a pre-release:
https://github.com/wagnerwagner/merx/releases/tag/1.4.1-rc.1

@acabrkic
Copy link
Author

@tobiasfabian This fixed it, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants