feat: add 502, 503, 504 as non-deterministic errors

wevm · Feb 19, 2023 · 8ef068b · 8ef068b · vercel · Feb 19, 2023
1 parent 89ff839
commit 8ef068b
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 1 deletion.
diff --git a/.changeset/nervous-phones-serve.md b/.changeset/nervous-phones-serve.md
@@ -0,0 +1,5 @@
+---
+"viem": patch
+---
+
+Added `502`, `503` and `504` error codes as "non-deterministic" errors for `fallback` transport & retries.
diff --git a/src/utils/buildRequest.test.ts b/src/utils/buildRequest.test.ts
@@ -630,6 +630,30 @@ describe('isDeterministicError', () => {
     ).toBe(false)
   })
 
+  test('HttpRequestError (502)', () => {
+    expect(
+      isDeterministicError(
+        new HttpRequestError({ body: {}, details: '', status: 502, url: '' }),
+      ),
+    ).toBe(false)
+  })
+
+  test('HttpRequestError (503)', () => {
+    expect(
+      isDeterministicError(
+        new HttpRequestError({ body: {}, details: '', status: 503, url: '' }),
+      ),
+    ).toBe(false)
+  })
+
+  test('HttpRequestError (504)', () => {
+    expect(
+      isDeterministicError(
+        new HttpRequestError({ body: {}, details: '', status: 504, url: '' }),
+      ),
+    ).toBe(false)
+  })
+
   test('HttpRequestError (429)', () => {
     expect(
       isDeterministicError(

diff --git a/src/utils/buildRequest.ts b/src/utils/buildRequest.ts
@@ -26,7 +26,10 @@ export const isDeterministicError = (error: Error) => {
       error.status !== 408 &&
       error.status !== 413 &&
       error.status !== 429 &&
-      error.status !== 500
+      error.status !== 500 &&
+      error.status !== 502 &&
+      error.status !== 503 &&
+      error.status !== 504
     )
   return true
 }