Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant distinction between rmc.unit.time option POSIX and character #1035

Open
3 tasks
vincentvanhees opened this issue Feb 5, 2024 · 2 comments
Open
3 tasks

Comments

@vincentvanhees
Copy link
Member

What we have for option "POSIX" also works for option "character".

  • Deprecate "character" inside read.my.acc function and in documentation, and in check_params re-assign to "POSIX" if user supplies "character".
  • Add check that P$timestamp in read.myacc.csv does not become NA, and provide informative error. For example, by plotting rmc.format.time and the first timestamp before it got converted to NA.
  • Add documentation on the imputation of missing decimal places, which is done but not in read.myacc.csv vignette.
@vincentvanhees
Copy link
Member Author

I have added the "help wanted" label as I do not have time and am not paid to work on this at the moment.

@vincentvanhees
Copy link
Member Author

Actually, because of the extra processing steps in POSIX it is much slower, so would be good to also investigate how to avoid slowing things down when merging the two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant