Update BlockHashCount in Transaction Mortality section
#4309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced the updated hard coded value with an rpc call
|
Hello @DrW3RK My apologies but I pushed a second commit after you approved that uses the |
|
All good. I was planning on doing it before merging! Thanks for fetching the value from the chain! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the Transaction Mortality section of the wiki it is mentioned that
BlockHashCountis set to2400blocks.However at line 81 of the Polkadot repo it looks like it was increased to
4096. The change happened in this PR from2400to4096.Also changed the hours from
fourtosevenby doing the following calculations (based on this Polkadot Parameters) :