Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same-origin prerendering triggered by speculationrules #667

Closed
mfalken opened this issue Aug 16, 2021 · 16 comments
Closed

Same-origin prerendering triggered by speculationrules #667

mfalken opened this issue Aug 16, 2021 · 16 comments
Assignees
Labels
chromium-high-priority Something that the Chromium team would like the TAG to prioritise Resolution: satisfied with concerns The TAG is satisfied with this work overall but requires changes Review type: CG early review An early review of general direction from a Community Group Venue: WHATWG

Comments

@mfalken
Copy link

mfalken commented Aug 16, 2021

Ya ya yawm TAG!

I'm requesting a TAG review of same-origin prerendereing triggered by speculationrules.

This feature is about the specific case of same-origin prerendering triggered by the speculation rules API.

This feature enables authors to provide a hint to the browser to prerender a URL, so the end-user can experience a near-instantaneous page load if that URL is visited.

Further details:

  • ✅ I have reviewed the TAG's Web Platform Design Principles
  • The group where the incubation/design work on this is being done (or is intended to be done in the future): WICG (future)
  • The group where standardization of this work is intended to be done ("unknown" if not known): WHATWG
  • Existing major pieces of multi-stakeholder review or discussion of this design: n/a
  • Major unresolved issues with or opposition to this design: none known
  • This work is being funded by: Google

You should also know that...

This feature is related to #611 in that it is a specific case of that triggering mechanism.

It is also related to #613, which is a particular API exposed by this feature.

We'd prefer the TAG provide feedback as (please delete all but the desired option):

☂️ open a single issue in our GitHub repo for the entire review

@mfalken mfalken added Progress: untriaged Review type: CG early review An early review of general direction from a Community Group labels Aug 16, 2021
@kenchris
Copy link

The "speculation rules API." URL doesn't work for me

@cynthia
Copy link
Member

cynthia commented Aug 17, 2021

@mfalken
Copy link
Author

mfalken commented Aug 17, 2021

Apologies, fixed, thanks.

@torgo
Copy link
Member

torgo commented Sep 16, 2021

Hi @mfalken - one thing to note is that Speculation Rules itself is still in a private repo.

@jeremyroman is this indeed in WICG? Yes there has been a positive TAG review that was based on an "early review" - if this feature itself is still in incubation then maybe it's premature to start building stuff on top of?

Regarding speculation rules, Chrome Status still shows "no signals" from other implementers or developers. Is there any multi-implementer activity? Again - a lack of consensus on speculation rules itself could mean that it's premature to base other features on it.

@torgo torgo added Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review Resolution: too early Possibly too early for review or not enough info provided and removed Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review labels Sep 27, 2021
@torgo
Copy link
Member

torgo commented Sep 27, 2021

We discussed it today and we've agreed it's premature for us to be reviewing this due to the status of speculation rules itself... Please can you request for the issue to be reopened when things have moved on a bit?

@torgo torgo closed this as completed Sep 27, 2021
@torgo torgo reopened this Nov 15, 2021
@torgo
Copy link
Member

torgo commented Nov 23, 2021

@mfalken great to see that Speculation Rules itself has moved into WICG - that's progress. However, Chromestatus still shows "no signal" for Safari, Firefox and also for developer feedback. Can you provide any further info?

@torgo torgo modified the milestones: 2021-11-22-week, 2021-12-06-F2F-Madripoor Nov 23, 2021
@jeremyroman
Copy link

@nyaxt @nhiroki should probably be the contacts for this on the Chromium side going forward (@mfalken is working on other projects now).

On the Speculation Rules side, we've received encouraging feedback for the overall effort in WICG/proposals#2 leading to the WICG/nav-speculation being created. Formal signals from Safari and Firefox in Chrome Status is generally populated by using their respective processes (webkit-dev, mozilla/standards-positions) and we're working on some updates before requesting those (along with other steps in standards-space).

@nhiroki
Copy link

nhiroki commented Nov 24, 2021

Thank you for mentioning us. Yes, @nyaxt and I are the new contacts of the Chromium impl.

@torgo
Copy link
Member

torgo commented Nov 24, 2021

Hi @nhiroki thanks for letting us know - can you give an update on the status?

@nhiroki
Copy link

nhiroki commented Nov 29, 2021

@torgo Chromium has already implemented the feature behind the runtime flag. We started Origin Trial from Chrome 94 (explainer) and will collect feedback from participants. In addition, we started upstreaming tests to the WPT repository.

@rhiaro
Copy link
Contributor

rhiaro commented Dec 7, 2021

Hi @nhiroki, we're looking at this in our virtual face-to-face today. Have you had chance to make progress on the issues I raised in our review feedback (#90)? Thanks.

@yoavweiss
Copy link

yoavweiss commented Jan 18, 2022

Have you had chance to make progress on the issues I raised in our review feedback (#90)?

Drive-by question: Is this the right issue? Naively, it seems unrelated..

@yoavweiss
Copy link

NM, Found the issue is WICG/nav-speculation#90

@torgo torgo modified the milestones: 2021-12-06-F2F-Madripoor, 2022-02-28-week Mar 1, 2022
@chrishtr chrishtr added the chromium-high-priority Something that the Chromium team would like the TAG to prioritise label Mar 1, 2022
@torgo torgo modified the milestones: 2022-02-28-week, 2022-03-14-week Mar 2, 2022
@torgo
Copy link
Member

torgo commented Mar 2, 2022

We will review the status of the 4 closed issues and decide whether to close this at the upcoming f2f.

@rhiaro
Copy link
Contributor

rhiaro commented Mar 25, 2022

We reviewed the six issues spun out from the TAG review at our face-to-face this week, and appreciate the thoughtful responses. We are happy to see this work move forward, with a few notes:

  • We look forward to reviewing a completed Security & Privacy Considerations section including mitigations, in the future. (In particular, regarding your note in the questionnaire: "But the user agent's heuristics deciding whether to honor a prerender hint can potentially leak information.")
  • We would like to see UA heuristics for prerendering developed publicly or even better in a standardised/normative way as a mitigation for some of the privacy concerns raised, or to discourage practices that may have a negative impact on end user control and choice.
  • I would like to reopen #101 - I've left a comment to clarify my question, but this isn't blocking.

@rhiaro rhiaro added Progress: propose closing we think it should be closed but are waiting on some feedback or consensus and removed Resolution: too early Possibly too early for review or not enough info provided labels Mar 25, 2022
@rhiaro rhiaro modified the milestones: 2022-03-14-week, 2022-03-28-week Mar 25, 2022
@torgo torgo modified the milestones: 2022-03-28-week, 2022-04-04-week Mar 30, 2022
@rhiaro
Copy link
Contributor

rhiaro commented Apr 4, 2022

Hi @mfalken, @jeremyroman, @KenjiBaheux, just following up on my previous comment. Would you mind reopening issue 101? Thanks!

@rhiaro rhiaro closed this as completed Apr 4, 2022
@rhiaro rhiaro added Resolution: satisfied with concerns The TAG is satisfied with this work overall but requires changes and removed Progress: propose closing we think it should be closed but are waiting on some feedback or consensus labels Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chromium-high-priority Something that the Chromium team would like the TAG to prioritise Resolution: satisfied with concerns The TAG is satisfied with this work overall but requires changes Review type: CG early review An early review of general direction from a Community Group Venue: WHATWG
Projects
None yet
Development

No branches or pull requests

10 participants