Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support codec and container switching with MSE using SourceBuffer.changeType() #298

Closed
3 of 5 tasks
wolenetz opened this issue Aug 14, 2018 · 5 comments
Closed
3 of 5 tasks
Assignees

Comments

@wolenetz
Copy link

Bonjour TAG,

I'm requesting a TAG review of:

Further details (optional):

Firefox 63+ contains an implementation of this new API (SourceBuffer.changeType()) on-by-default.
Chrome 69+ contains an implementation conditioned by chrome://flags#enable-experimental-web-platform-features, and the intent-to-ship it on-by-default is currently pending approvals.

Please go by the editor's draft, not the explainer (the explainer predated the spec, and some small things have changed such as changeType() is a void, not boolean method; it throws if called in bad state or if the change isn't supported.) I'll be updating the explainer this week to make it reflect the spec more precisely.

We'd prefer the TAG provide feedback as (please select one):

  • open issues in our Github repo for each point of feedback
  • open a single issue in our Github repo for the entire review
  • leave review feedback as a comment in this issue and @-notify [wolenetz, jyavenard]

Thank you!

@travisleithead
Copy link
Contributor

I will note that this has lots of support from various teams inside of Microsoft. :)

@wolenetz
Copy link
Author

Safari Technical Preview, as of at least a week ago, also contained an experimental implementation of SourceBuffer.changeType(). @jernoble

@plinss plinss added this to the 2018-10-09-telcon milestone Sep 18, 2018
@cynthia
Copy link
Member

cynthia commented Oct 9, 2018

We're happy to see this addition (bug fix?) to the feature set of MSE. As a much needed addition to the currently shipping MSE API, I don't think we have any notable objections towards the design or functionality of the proposal.

(I do state we, but I haven't actually discussed this with the rest of the group yet. To be brought up in a upcoming call.)

@travisleithead
Copy link
Contributor

Likewise, have reviewed this, and have no outstanding concerns. Really appreciate the detailed explainer and concerns and design alternatives considered.

@torgo torgo changed the title TAG Review Request: Support codec and container switching with MSE using SourceBuffer.changeType() Support codec and container switching with MSE using SourceBuffer.changeType() Oct 30, 2018
@cynthia
Copy link
Member

cynthia commented Oct 31, 2018

Taken up at Paris F2F, we're happy to see this work move forward - thanks for bringing this to our attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants