Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Picked Hero Overview #216

Closed
phil-zxx opened this issue Oct 22, 2020 · 11 comments
Closed

Improve Picked Hero Overview #216

phil-zxx opened this issue Oct 22, 2020 · 11 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@phil-zxx
Copy link

I was wondering if it's worth updating the picked hero overview https://www.w3champions.com/OverallStatistics/heroes-winrates:

  1. Group by Race (HU, ORC, UD, NE & Tavern) and sort by picked hero count within each group. That way, it's a lot easier (and more intuitive) to find heroes in the graph.
  2. Instead of showing a total count, show a percentage (normalised by race). That way, we can actually compare whether e.g. HU players choose AM more than NE players choose DH.

I've attached examples for 1on1 & FFA. Happy to help, if necessary.

image

@abeninski
Copy link
Contributor

Yeah good idea. Would be awesome if you can help with implementation.

@Cepheid-UK Cepheid-UK added the enhancement New feature or request label Oct 23, 2020
@Cepheid-UK
Copy link
Member

Cepheid-UK commented Oct 23, 2020

On the site we use ChartJS for all the graphs.

This PR should give some clues as to how stacked bars could be implemented:

chartjs/Chart.js#3563

@Cepheid-UK Cepheid-UK added the good first issue Good for newcomers label Oct 23, 2020
@ghost
Copy link

ghost commented Oct 24, 2020

I will start working on this. I don't have permissions yet to assign this to myself.

@modmoto modmoto assigned modmoto and ghost and unassigned modmoto Oct 26, 2020
@modmoto
Copy link
Member

modmoto commented Oct 26, 2020

Looks nice, how about one color per race? Makes the coloring more clear. For example between NE and UD, the colors are hard to distinguish. Like blue for HU, red orc, teal ne, purple ud and yellow for neutral.
I assigned your name btw.

@phil-zxx
Copy link
Author

I really like the look of it. Maybe also add some (white) space between each race; as in my original suggestion (since it helps visually to have each race in its own block).

@ghost
Copy link

ghost commented Oct 26, 2020

image
image
image

@phil-zxx @modmoto Here are some updated screenshots. It might be a bit tricky to get spacing in there but I'll give it a go.

@Cepheid-UK
Copy link
Member

Looks really good!

@ghost
Copy link

ghost commented Oct 26, 2020

Without having the played race, the percentage will not be correct.

I think that the endpoint will need to be updated to return the played race as well.

The way it is now, when calculating by race, if they picked a tavern hero that will throw off the percentages. Also, this way one can filter by race as well.

I think it would also be helpful to filter by season.

I'll put in a pull request for what I have and then create new issues to address the above concerns.

@alocate
Copy link
Contributor

alocate commented Oct 26, 2020

there will always be an issue when a random player picks only tavern heroes. maybe filter out random players entirely? Should be less than 10% of games in solo.

@ghost
Copy link

ghost commented Oct 26, 2020

there will always be an issue when a random player picks only tavern heroes. maybe filter out random players entirely? Should be less than 10% of games in solo.

Yeah I was thinking about how random and tavern heroes affected this.

My thought is that if we can get picked race and then actual race and group the data by that then we can add a drop-down to filter this in a meaningful way.

I think these dropdowns would need to be added to add more usefulness to the data:

  • season
  • race
  • for this I think it would contain this:
    All
    Human
    Orc
    NE
    Undead
    Random - Human
    Random - Orc
    Random - NE
    Random - Undead

In the future it may be nice to have one for map as well.

@gustav87
Copy link
Contributor

gustav87 commented Mar 7, 2023

Completed.

@gustav87 gustav87 closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants