-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Picked Hero Overview #216
Comments
Yeah good idea. Would be awesome if you can help with implementation. |
On the site we use ChartJS for all the graphs. This PR should give some clues as to how stacked bars could be implemented: |
I will start working on this. I don't have permissions yet to assign this to myself. |
Looks nice, how about one color per race? Makes the coloring more clear. For example between NE and UD, the colors are hard to distinguish. Like blue for HU, red orc, teal ne, purple ud and yellow for neutral. |
I really like the look of it. Maybe also add some (white) space between each race; as in my original suggestion (since it helps visually to have each race in its own block). |
Looks really good! |
Without having the played race, the percentage will not be correct. I think that the endpoint will need to be updated to return the played race as well. The way it is now, when calculating by race, if they picked a tavern hero that will throw off the percentages. Also, this way one can filter by race as well. I think it would also be helpful to filter by season. I'll put in a pull request for what I have and then create new issues to address the above concerns. |
there will always be an issue when a random player picks only tavern heroes. maybe filter out random players entirely? Should be less than 10% of games in solo. |
Yeah I was thinking about how random and tavern heroes affected this. My thought is that if we can get picked race and then actual race and group the data by that then we can add a drop-down to filter this in a meaningful way. I think these dropdowns would need to be added to add more usefulness to the data:
In the future it may be nice to have one for map as well. |
Completed. |
I was wondering if it's worth updating the picked hero overview https://www.w3champions.com/OverallStatistics/heroes-winrates:
I've attached examples for 1on1 & FFA. Happy to help, if necessary.
The text was updated successfully, but these errors were encountered: