Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we add captureTimestamp senderCaptureTimeOffset to the RTCEncodedXXXFrameMetadata if abs-capture-time is used? #225

Open
murillo128 opened this issue Feb 27, 2024 · 4 comments · May be fixed by #228
Open

Should we add captureTimestamp senderCaptureTimeOffset to the RTCEncodedXXXFrameMetadata if abs-capture-time is used? #225

murillo128 opened this issue Feb 27, 2024 · 4 comments · May be fixed by #228

Comments

@murillo128
Copy link

murillo128 commented Feb 27, 2024 •
edited by aboba
Loading

In the https://w3c.github.io/webrtc-extensions/ we define the captureTimestamp and senderCaptureTimeOffset at contribution source level, however this information is available on a per frame level too.

I believe it would be interesting to be able to expose the same both values in the RTCEncodedAudioFrameMetadata and RTCEncodedVideoFrameMetadata when the abs capture time header extension is used.

Related: PR 137
@tonyherre
Copy link
Contributor

tonyherre commented Feb 28, 2024 •
edited
Loading

+1 would be great to have. I'd say it should ~always be exposed for locally captured frames, like how we have for requestVideoFrameCallback, and exposed for remote frames if and only if the abs-capture-time is sent.

@Orphis FYI

@stefanholmer
Copy link

It would also be useful to add the receiveTime on the receiver-side, in the same way we do for requestVideoFrameCallback.

@murillo128 murillo128 mentioned this issue Mar 5, 2024
Open
@guidou
Copy link
Collaborator

guidou commented Mar 6, 2024

cc @tonyherre

Orphis added a commit to Orphis/webrtc-encoded-transform that referenced this issue May 2, 2024
@Orphis
Add captureTimestamp and senderCaptureTimeOffset to frame metadata
71a2372 
Fixes w3c#225
@Orphis Orphis linked a pull request May 2, 2024 that will close this issue
Open
@dontcallmedom-bot
Copy link

This issue had an associated resolution in WebRTC Interim, May 21st – 21 May 2024 (Issue 225: Add captureTimestamp senderCaptureTimeOffset to the encoded frame metadata):

RESOLUTION: next step on issue 225 is to review the PR

Orphis added a commit to Orphis/webrtc-encoded-transform that referenced this issue Jun 19, 2024
@Orphis
Add captureTimestamp and senderCaptureTimeOffset to frame metadata
740b9cf 
Fixes w3c#225
Orphis added a commit to Orphis/webrtc-encoded-transform that referenced this issue Jun 20, 2024
@Orphis
Add captureTimestamp and senderCaptureTimeOffset to frame metadata
1613039 
Fixes w3c#225
Orphis added a commit to Orphis/webrtc-encoded-transform that referenced this issue Jun 20, 2024
@Orphis
Add captureTimestamp and senderCaptureTimeOffset to frame metadata
1a211a1 
Fixes w3c#225
@guidou guidou mentioned this issue Dec 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add captureTimestamp and senderCaptureTimeOffset to frame metadata Orphis/webrtc-encoded-transform
5 participants
@stefanholmer @murillo128 @guidou @dontcallmedom-bot @tonyherre