Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Ignore unsupported properties in manifest.json #355

Closed
erosman opened this issue Feb 24, 2023 · 1 comment
Closed

Proposal: Ignore unsupported properties in manifest.json #355

erosman opened this issue Feb 24, 2023 · 1 comment
Labels
status: duplicate Duplicate issue

Comments

@erosman
Copy link

erosman commented Feb 24, 2023

Purpose

Using the same manifest.json for all browsers

Proposal

Ignore unsupported properties in manifest.json

As mentioned in #282, handling of unsupported properties in mafinset.json requires a consensus.

Currently browser specific entries often result in failure.

Examples:

  • Firefox Specific: browser_specific_settings
  • Chrome Specific: minimum_chrome_version, key
@Rob--W
Copy link
Member

Rob--W commented Feb 24, 2023

Duplicate of #14.

Side note: both of your examples (browser_specific_settings and minimum_chrome_version) do not result in hard failures.

@Rob--W Rob--W added status: duplicate Duplicate issue and removed needs-triage labels Feb 24, 2023
@Rob--W Rob--W closed this as completed Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: duplicate Duplicate issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rob--W @erosman