Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transient Echnida publication issue #261

Closed
padenot opened this issue May 27, 2021 · 4 comments
Closed

Transient Echnida publication issue #261

padenot opened this issue May 27, 2021 · 4 comments
Labels

Comments

@padenot
Copy link
Collaborator

padenot commented May 27, 2021

See this run: https://github.com/w3c/webcodecs/runs/2683472964?check_suite_focus=true#step:3:162 (https://labs.w3.org/echidna/api/status?id=6a05c4fc-00b8-4a58-8128-bbf5626ed7b7 is the echnida log). I did a few retriggers here and there, and it's someone random.

Looks like some IPs from github are not whitelisted? @tidoust Is this known?

@tidoust
Copy link
Member

tidoust commented May 27, 2021

Ping @deniak and @jennyliang220.

@deniak
Copy link
Member

deniak commented May 27, 2021

That's odd! Echidna tries to fetch all the github actions IPs from their API: https://api.github.com/meta.
As I'm writing this, 20.98.226.174 isn't part of the actions list.
I'll send an email to the GitHub support to see if there's any reason that IP isn't listed there.

@deniak
Copy link
Member

deniak commented May 31, 2021

The support finally replied and here's their answer.

Ahh sorry about that, I believe this is possible because the API is updated once a week for these IP addresses, we mention that here:

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#ip-addresses

So I think after the next update, that IP address should be covered in the API.

The Azure IP addresses are available here:

https://www.microsoft.com/en-us/download/details.aspx?id=56519

And I believe this information shouldn't have the same lag if you need more up-to-date IP addresses.

We are currently relying on the github API to fetch the list of IPs but the list isn't as reliable as we'd thought.

@tidoust
Copy link
Member

tidoust commented Feb 17, 2023

This was fixed a long time ago. Closing...

@tidoust tidoust closed this as completed Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants