Issue #294 - Add a non-normative comment about snapshotting BufferSources #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fer source" [=get a copy of the bytes held by the buffer source=] should have autolinked to WebIDL, but it wasn't. I tried debugging it for a bit, but ultimately decided to just manually specify the link. I think if a bikeshed expert wants to fix this, go right ahead, but this works presently.
|
Note in 8f93864 I added an explicit link to heycam/webidl to get an explicit link from "get a copy of the bytes held by the buffer source" to https://heycam.github.io/webidl/#dfn-get-buffer-source-reference. As I mention in the commit message, this is not how we normally do things, but Bikeshed refused to acknowledge that " Anyway, these two commits together, while not perfectly clean, are safe. As long as the text looks good, we should feel OK to proceed. |
equalsJeffH
approved these changes
Sep 19, 2018
|
Thanks for the reviews! |
WebAuthnBot
pushed a commit
that referenced
this pull request
Sep 19, 2018
…about snapshotting BufferSources (#1074)
WebAuthnBot
pushed a commit
that referenced
this pull request
Sep 19, 2018
…about snapshotting BufferSources (#1074)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly different text than #294 (comment).
Preview | Diff