Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base64-related requirements are broken #121

Open
annevk opened this issue Apr 21, 2023 · 0 comments
Open

base64-related requirements are broken #121

annevk opened this issue Apr 21, 2023 · 0 comments

Comments

@annevk
Copy link
Member

annevk commented Apr 21, 2023

Let's track this part of #84 separately.

It's currently unclear what kind of base64 decoding is used and what kind of restrictions are enforced.

From code inspection in WebKit it appears that both base64 and base64url decoding are attempted, both without enforcing padding restrictions. That doesn't strike me as great from a security perspective. If we could model it as instead as encoding and then comparing for strict equality that would be vastly preferable, but there are some tests that would be impacted by this.

Corresponding CSP issue: w3c/webappsec-csp#423.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant