[feature-policy] Avoid timeouts in absence of API #10621
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many tests written for the `document.policy.allowedFeatures` method reference the API without first ensuring its availability. The method is a new addition to the web platform, so this pattern produces a ReferenceError in many browsers (i.e. all major browsers at the time of this writing). Because the error occurs in the context of an iframe, the test harness is unable to detect it, and the affected tests report an error only following an extended delay. Guard the reference with a `try`/`catch` block so that failures are detected and reported immediately.
zcorpan
approved these changes
Apr 25, 2018
|
@clelland Would you mind taking a look? |
|
In the two months that this pull request has been awaiting review, another contributor has submitted a patch to correct the problem: gh-11270. That patch was merged yesterday, so this is no longer necessary. |
|
Sorry I forgot about this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many tests written for the
document.policy.allowedFeaturesmethodreference the API without first ensuring its availability. The method is
a new addition to the web platform, so this pattern produces a
ReferenceError in many browsers (i.e. all major browsers at the time of
this writing). Because the error occurs in the context of an iframe, the
test harness is unable to detect it, and the affected tests report an
error only following an extended delay.
Guard the reference with a
try/catchblock so that failures aredetected and reported immediately.
Here are the results of the command
./wpt run --include feature-policy chromebefore applying this patch:And after: