-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bikeshedding the name for the vc-jwt
1.1 cty
value.
#42
Comments
vc-jwt
1.1 cty
vc-jwt
1.1 cty
value.
It's a subtype of I am not sure whether something like I still do not understand the wish or need to include
Can anyone help me understand this? What are the anticipated differences between data in media type |
Also, I'm not exactly sure what the need is for 1.1 in the name, is it related to the "instead of / in addition to" language? With respect to that language, perhaps it would be better to have two different media types:
The 1.1 spec discusses these three things in JSON format:
{
"@context": [...],
"type": ["VerifiableCredential", "..."],
"id": "<credentialId>",
"issuer": "<issuerId>",
"credentialSubject": {
"id": "<subjectId>",
...
},
"issuanceDate": "<issuanceDate>",
...
}
{
"jti": "<credentialId>",
"iss": "<issuerId>",
"nbf": "<unix-time-stamp-encoded issuanceDate>",
"sub": "<subjectId>",
"vc": {
"@context": [...],
"type": ["VerifiableCredential", "..."],
"id": "<credentialId>",
"issuer": "<issuerId>",
"credentialSubject": {
"id": "<subjectId>",
...
},
"issuanceDate": "<issuanceDate>",
...
}
}
{
"jti": "<credentialId>",
"iss": "<issuerId>",
"nbf": "<unix-time-stamp-encoded issuanceDate>",
"sub": "<subjectId>",
"vc": {
"@context": [...],
"type": ["VerifiableCredential", "..."],
// "id", "issuer", "issuanceDate", fields removed
"credentialSubject": {
// "id" field removed
...
},
...
}
} The latter two would share the media type: |
Also, for anyone who didn't read the comments in the related PR, I'm linking to my comments there on what the JSON Web Token Best Current Practices RFC has to say on using "Explicit Types". Notably, the advice is to use the I understand the media type being discussed in this issue is meant to represent the JWT Claims Set, not the JWT itself, however, it may be worth reconsidering whether that's the best approach to addressing use cases vs. following the advice in the JWT Best Current Practices RFC. |
I think we have addressed this feedback in the latest draft, please review and let me know if you think this issue is actionable, what action you would like to see. |
Removing the 1.1 stuff and fixing the media types (both of which have been done in the latest draft) addresses my concerns here. Anything else I raised around following best practices is there for anyone to review if they want to ensure what we're doing follows those, I have nothing more to say on that either way. I'm happy for this issue to be closed if others feel similarly. |
Marked pending close over 1 week ago, closing. |
See the original PR here: #40
The original proposal was :
application/credential-1.1+json
The name was modified to:
application/credential-claims-set-1.1+json
The editors noted that "claim-set" is redundant.
The text was updated successfully, but these errors were encountered: