Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Window with WindowProxy in IDL throughout? #388

Open
awesomekling opened this issue Nov 17, 2024 · 1 comment
Open

Replace Window with WindowProxy in IDL throughout? #388

awesomekling opened this issue Nov 17, 2024 · 1 comment

Comments

@awesomekling
Copy link

The HTML spec returns WindowProxy for Document.defaultView: https://html.spec.whatwg.org/#dom-document-defaultview

Should the uses of Window in UIEvents IDL also be WindowProxy instead?

FWIW WebKit has been using WindowProxy since 2018: https://bugs.webkit.org/show_bug.cgi?id=185022
awesomekling added a commit to awesomekling/ladybird that referenced this issue Nov 17, 2024
@awesomekling
LibWeb: Use WindowProxy instead of Window in UI Events IDL
2dcecdf 
I believe this is an error in the UI Events spec, and it should be
updated to match the HTML spec (which uses WindowProxy everywhere).

This fixes a bunch of issues already covered by existing WPT tests.

Spec bug: w3c/uievents#388

Note that WebKit has been using WindowProxy instead of Window in
UI Events IDL since 2018:
WebKit/WebKit@816158b
@awesomekling awesomekling mentioned this issue Nov 17, 2024
Merged
awesomekling added a commit to LadybirdBrowser/ladybird that referenced this issue Nov 17, 2024
@awesomekling
LibWeb: Use WindowProxy instead of Window in UI Events IDL
3e8c8b1 
I believe this is an error in the UI Events spec, and it should be
updated to match the HTML spec (which uses WindowProxy everywhere).

This fixes a bunch of issues already covered by existing WPT tests.

Spec bug: w3c/uievents#388

Note that WebKit has been using WindowProxy instead of Window in
UI Events IDL since 2018:
WebKit/WebKit@816158b
@jamierocks
Copy link

Related PR (albeit in the other direction): #379

gotlougit pushed a commit to gotlougit/ladybird that referenced this issue Nov 21, 2024
@awesomekling @gotlougit
LibWeb: Use WindowProxy instead of Window in UI Events IDL
45f5b4e 
I believe this is an error in the UI Events spec, and it should be
updated to match the HTML spec (which uses WindowProxy everywhere).

This fixes a bunch of issues already covered by existing WPT tests.

Spec bug: w3c/uievents#388

Note that WebKit has been using WindowProxy instead of Window in
UI Events IDL since 2018:
WebKit/WebKit@816158b
nico-engels pushed a commit to nico-engels/ladybird that referenced this issue Nov 23, 2024
@awesomekling @nico-engels
LibWeb: Use WindowProxy instead of Window in UI Events IDL
0aa6c8e 
I believe this is an error in the UI Events spec, and it should be
updated to match the HTML spec (which uses WindowProxy everywhere).

This fixes a bunch of issues already covered by existing WPT tests.

Spec bug: w3c/uievents#388

Note that WebKit has been using WindowProxy instead of Window in
UI Events IDL since 2018:
WebKit/WebKit@816158b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamierocks @awesomekling