-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APCA constants - consistent naming #225
Comments
If I understand it, just the consistency between the code and the LaTeX svg? I probably should just lose the LaTeX as it's probably more confusing than helpful. The constants in the LaTeX are intentionally different, as it originated at a time when the code was changing rapidly including variable names etc. The LaTeX does not really serve a purpose anymore as I think of it. It would probably be best at this point to create a pseudocode, or just show the basic JS. Regarding PR w3c/silver#213 or w3c/silver#570 (or the w3c/silver#568 which I closed to make w3c/silver#570, trying to figure out why they are not being merged, and not getting any answers) Most recently I was told that that entire page would be deleted so that it was no longer something linked to, which is probably ideal. Regarding the D65 and the chromaticity coefficients: I am using the BruceLindbloom ones also intentionally, as there was some experimentation in the past regarding the coefficients relating to certain impairments, and I wanted it to be easily recognizable that they were different. But as discussed in other threads, those will change as I align things to the CSS 4 values for all of the standard "CIE/IEC" stuff. |
As long as the equations are clearly documented such that they can be independently implemented. |
I am working on organizing and cleaning up documentation, and streamlining it to improve access and understanding. |
(I would raise an issue on the constants in WCAG 3, but they haven't been added yet until w3c/silver#570 is merged)
The problem
The Current APCA Constants ( 0.0.98G - W3 last changed Feb 15, 2021 ) lists constants, but gives no equations.
The APCA Base Math (sRGB) lists constants and equations, but the names used are not the same and the set of constants is not exactly equivalent.
When implementing, I mainly used the value of the constants to check equivalence (which kind of defeats the point of named constants) but clearly this fails if two constants have the same value and the mapping is not immediately obvious.
Correspondences
The correspondences seem to be:
Suggested fixes
Also
In addition, please be aware that the chosen 5-digit chromaticity values for D65 differ slightly from the 4-digit ones used in CSS Color 4 (the latter being changed several times, although we finally went for the 4-digit ones throughout for consistency with the defining color space specifications) and also that the matrix coefficients for RGB to Y also differ from both CSS and the sRGB specification. The CSS ones were calculated from first principles and agree with the sRGB standard ones when rounded to 8 significant figures.
The text was updated successfully, but these errors were encountered: