Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does PushManager subscribe() need transient activation check? #346

Open
youennf opened this issue Mar 22, 2022 · 2 comments · May be fixed by #348
Open

Does PushManager subscribe() need transient activation check? #346

youennf opened this issue Mar 22, 2022 · 2 comments · May be fixed by #348
Assignees
@marcoscaceres

Comments

@youennf
Copy link

youennf commented Mar 22, 2022

https://w3c.github.io/push-api/#dom-pushmanager-subscribe does not mention whether a https://html.spec.whatwg.org/multipage/interaction.html#transient-activation check should be done.
AIUI, Chrome and Firefox enforce these checks and WebKit is about to add this check at https://bugs.webkit.org/attachment.cgi?id=455337&action=review.
Would it make sense to update the spec accordingly?
@marcoscaceres marcoscaceres self-assigned this May 31, 2022
@marcoscaceres
Copy link
Member

marcoscaceres commented May 31, 2022 •
edited
Loading

Yeah, the spec predates the new gesture model. I'll update the spec.

@marcoscaceres
Copy link
Member

@youennf, wrote:

Chrome and Firefox enforce these checks and WebKit is about to add this check at

I did some tests and checked the code of what Chrome and Firefox do... it seems that they don't consume the user activation.

Irrespective, I think it makes sense to consume the user active activation when calling subscribe().

@marcoscaceres marcoscaceres changed the title PushManager subscribe method probably needs a transient activation check Does PushManager subscribe() need transient activation check? Jun 1, 2022
@marcoscaceres marcoscaceres linked a pull request Jun 1, 2022 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcoscaceres marcoscaceres

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

check and consume user activation w3c/push-api
2 participants
@marcoscaceres @youennf