Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BikeShed nits #148

Closed
marcoscaceres opened this issue Jun 3, 2019 · 5 comments
Closed

BikeShed nits #148

marcoscaceres opened this issue Jun 3, 2019 · 5 comments

Comments

@marcoscaceres
Copy link
Member

Just a small thing... when talking about content attributes VS IDL attributes, make sure you use this syntax for content attributes:

<{element/attribute}>

So:

<{video/disablePictureInPicture}>
@marcoscaceres
Copy link
Member Author

More details here: https://tabatkins.github.io/bikeshed/#autolink-wrappers

@beaufortfrancois
Copy link
Collaborator

@marcoscaceres As I'm always referring to IDL attributes, I guess we're good right?

@marcoscaceres
Copy link
Member Author

Yep, if that's the case, then sure...

@marcoscaceres
Copy link
Member Author

Actually, this doesn't appear to be true...

@marcoscaceres marcoscaceres reopened this Jun 11, 2020
@beaufortfrancois beaufortfrancois mentioned this issue Jun 12, 2020
Closed
@beaufortfrancois
Copy link
Collaborator

Fixed with #187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beaufortfrancois @marcoscaceres