Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PermissionDescriptor equality is not defined #396

Open
annevk opened this issue Nov 24, 2022 · 1 comment
Open

PermissionDescriptor equality is not defined #396

annevk opened this issue Nov 24, 2022 · 1 comment

Comments

@annevk
Copy link
Member

annevk commented Nov 24, 2022

The specification doesn't appear to use equality anywhere, but it's rather unclear to me how anything could work without it. Presumably we don't want the default identity equality to be used here.

It's also unclear how the specification integrates with the "stronger than" concept.

@jyasskin
Copy link
Member

Right, I think I had structural equality in mind when I wrote things like "with the same descriptor and settings," but that wasn't clear from the wording.

The only implication of "stronger than" is the requirement on permission states that's included in its definition. I should probably have used it in the "permission state" definition, along the lines of «If there was a previous invocation of this algorithm for the same |feature| that returned "granted", and the previous invocation's descriptor was [=stronger than=] this invocation's, return "granted"», and the converse for "denied". With the new permission store model, I think it might fit better in https://www.w3.org/TR/permissions/#requesting-more-permission, where you'd look for stronger and weaker descriptors before asking the user to express permission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants